Details
Description
Having a look into the init script from mariadb-galera-server-5.5 I see some things that are not good. Some of them also fit to mariadb in general.
- kill -9 (See Bug #870310)
- killall mysqld (Do I really want to kill all running mysqld?)
Things that are not good for Galera or are missing for a better Galera support.
- Relying on a credentials file (/etc/mysql/debian.cnf). This is always bad, because it is inconsistent. Restarting/Status-Check a server will break, because the credentials in the file does not match the ones in the database. I wonder why not use any socket-auth.
- Missing Bootstrap for Galera. PXC ships with a bootstrap option. May be worth to think about it.
- The --wsrep-recover Option is ignored. This will most likely prevent a SST after a crash, as it can be used to get the last committed seqno
Gliffy Diagrams
Attachments
Issue Links
- relates to
-
MDEV-703 LP:870310 - killall -9 in init-script
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Forget the wsrep-recover thing. It is in mysqld_safe and not in the init script.
Bug #870310 was (somewhat) fixed as
MDEV-703. Now the timeout is 10 min, and I'd say if it didn't shutdown properly in this time, something is most likely wrong, and it will have to be killed anyway. The reason for doing it in the script is the upgrade i think, which would hung if the server hangs on shutdown.killall is still present though.
For the Galera issues, Jan, could you please take a look and decide whether it should be done on our side or we should reassign it to Seppo? And if it's to be done on our side, please decide between you and Holyfoot who would be doing it.
As far as I know, the script gets merges from Codership, but at some point it was touched by Holyfoot as well, as a part of
MDEV-507.Thanks.