Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4998

Audit plugin: Add a possibility to turn off log rotation

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Based on the testing comments:

      well it's easy thing to do. The initial idea was if the server_audit_file_rotations is 0,
      that means no rotations at all.
      The i decided not to do that as one has to limit the size of the log file somehow anyway.
      And one can virtually turn off the rotation by setting a huge server_audit_file_rotate_size.
      Elena, what is your opinion about that?

      I absolutely think that it should be done, especially if it's an easy thing to do. Doing it via setting server_audit_file_rotations to 0 is fine with me, it's intuitive enough, I actually tried it the first thing after I saw that there was no boolean variable for rotation, only to find out that it didn't work, the value was adjusted to 1.

      Doing it via server_audit_file_rotate_size, on the other hand, is dirty and is only acceptable as a temporary workaround.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              holyfoot Alexey Botchkov added a comment -

              Implemented so the server_audit_file_rotations=0 means the log never rotates.

              Show
              holyfoot Alexey Botchkov added a comment - Implemented so the server_audit_file_rotations=0 means the log never rotates.

                People

                • Assignee:
                  holyfoot Alexey Botchkov
                  Reporter:
                  elenst Elena Stepanova
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 3 hours
                    3h