Details
-
Type:
Task
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
Description
[Affected version: at least 5.5.28a-MariaDB-log]
When a user performs queries handled by query-cache theses are not taken into account by USER_STATISTICS (and probably neither by HOST_STATISTICS).
They should properly increment COMMAND_SELECT, SENT_ROWS and when appropriate EMPTY_QUERIES.
Without updating those a user that performs the same SELECT over and over, each time hitting query cache will appear as performing no queries, just burning CPU time and exchanging bytes.
Gliffy Diagrams
Attachments
Issue Links
- relates to
-
MDEV-7216 COM_Select goes up together with Qcache_hits
-
- Open
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
QC should be transparent, so SELECT_COMMANDS should count QC answers.
Normal execution is fixed. now have to check SP and PS.
EMPTY_QUERIES (both) counts queries with empty results (So I was wrong initially).
Committed for review.
pushed to 5.5
After some digging into sources I found that EMPTY_QUERIES counts really empty queries (when parser faces EOF and put SQLCOM_EMPTY_QUERY as a command, which is irrelevant to SQLCOM_SELECT completely)