Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4904

Add query cache hit information to Percona Response time distribution plugin (MDEV-4568)

    Details

    • Type: Task
    • Status: Stalled
    • Priority: Major
    • Resolution: Unresolved
    • Fix Version/s: 10.1
    • Component/s: None
    • Labels:
      None

      Description

      Include two new columns to QUERY_RESPONSE_TIME:
      query_cache_count => number of queries returned from query cache
      query_cache_total => query cache response time

      the non query cache queries could be found as:
      SELECT
      time,
      count,
      total,
      query_cache_count,
      query_cache_total,
      (count-query_cache_count) AS non_query_cache_count,
      (total-query_cache_total) AS non_query_cache_total
      FROM QUERY_RESPONSE_TIME

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              svoj Sergey Vojtovich added a comment -

              Roberto,

              what was the use case for this feature? Filtering out QC hits?

              Show
              svoj Sergey Vojtovich added a comment - Roberto, what was the use case for this feature? Filtering out QC hits?
              Hide
              rspadim roberto spadim added a comment -

              For current mdev, know what was the exactly time take from standard queriess and query cached queriess, usefull to fine tune apps
              Fornthe other mdev, know if a query cached is a good/bad cached query and agaim fine tune app and query cache use

              Show
              rspadim roberto spadim added a comment - For current mdev, know what was the exactly time take from standard queriess and query cached queriess, usefull to fine tune apps Fornthe other mdev, know if a query cached is a good/bad cached query and agaim fine tune app and query cache use
              Hide
              svoj Sergey Vojtovich added a comment -

              Quoting Sergei's review:

              Queries served from qc don't take much time, which means that @@query_response_time_range_base should be different for them. Otherwise all qc hits will be in the first few slots. But a different base means a different table (QUERY_CACHE_RESPONSE_TIME ?) and a different set of configuration variables.

              Isn't it the case?

              Show
              svoj Sergey Vojtovich added a comment - Quoting Sergei's review: Queries served from qc don't take much time, which means that @@query_response_time_range_base should be different for them. Otherwise all qc hits will be in the first few slots. But a different base means a different table (QUERY_CACHE_RESPONSE_TIME ?) and a different set of configuration variables. Isn't it the case?
              Hide
              rspadim roberto spadim added a comment -

              Well from my tests with a pentium 3 i got 30ms from query cache, the biggest qc return was 147 ms ,

              Show
              rspadim roberto spadim added a comment - Well from my tests with a pentium 3 i got 30ms from query cache, the biggest qc return was 147 ms ,
              Hide
              rspadim roberto spadim added a comment -

              just to add a comment and a feature usefull..

              when we restart the stats should be nice when it happened, maybe a status variable (show status) reporting the last flush could be very usefull to get informatino about "queries/second" (now-flush datetime)

              Show
              rspadim roberto spadim added a comment - just to add a comment and a feature usefull.. when we restart the stats should be nice when it happened, maybe a status variable (show status) reporting the last flush could be very usefull to get informatino about "queries/second" (now-flush datetime)

                People

                • Assignee:
                  svoj Sergey Vojtovich
                  Reporter:
                  rspadim roberto spadim
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:

                    Time Tracking

                    Estimated:
                    Original Estimate - 3 hours
                    3h
                    Remaining:
                    Time Spent - 1 hour, 40 minutes Remaining Estimate - 1 hour, 20 minutes
                    1h 20m
                    Logged:
                    Time Spent - 1 hour, 40 minutes Remaining Estimate - 1 hour, 20 minutes
                    1h 40m