Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4788

check mysql-5.5 changes in spatial.cc

        Details

        • Type: Task
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Fix Version/s: None
        • Component/s: None
        • Labels:
          None

          Description

          mysql-5.5.32 fixes crashes in spatial.cc.
          We've had these fixes for a while already.
          But

          • mysql fixes them slightly differently
          • it fixes less functions than we do
            we need to compare implementations, see which one to choose and it we use the upstream version — fix other functions to use the same style of checking

            Gliffy Diagrams

              Attachments

                Issue Links

                is blocked by

                Task - A task that needs to be done. MDEV-4763 5.5.32 merge

                • Blocker - Blocks development and/or testing work, production could not run.
                • Closed

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  serg Sergei Golubchik added a comment -

                  I've reverted mysql changes, they didn't pass our test suite. Still, please check what they were

                  Show
                  serg Sergei Golubchik added a comment - I've reverted mysql changes, they didn't pass our test suite. Still, please check what they were
                  Hide
                  Permalink
                  holyfoot Alexey Botchkov added a comment -

                  Patch for 5.1 pushed:
                  http://lists.askmonty.org/pipermail/commits/2013-July/005106.html.

                  Show
                  holyfoot Alexey Botchkov added a comment - Patch for 5.1 pushed: http://lists.askmonty.org/pipermail/commits/2013-July/005106.html .
                  Hide
                  Permalink
                  holyfoot Alexey Botchkov added a comment -

                  Additional patch for 5.5.
                  http://lists.askmonty.org/pipermail/commits/2013-October/005510.html

                  Show
                  holyfoot Alexey Botchkov added a comment - Additional patch for 5.5. http://lists.askmonty.org/pipermail/commits/2013-October/005510.html

                    People

                    • Assignee:
                      holyfoot Alexey Botchkov
                      Reporter:
                      serg Sergei Golubchik
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      2 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:

                        Time Tracking

                        Estimated:
                        Original Estimate - Not Specified
                        Not Specified
                        Remaining:
                        Remaining Estimate - 0 minutes
                        0m
                        Logged:
                        Time Spent - 5 hours
                        5h