Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4710

Merge Performance Schema test cases from MySQL 5.6.10

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 10.0.4
    • Component/s: None
    • Labels:
      None

      Description

      The goal of this task is to merge all test cases related to performance schema as of MySQL 5.6.10, and to make all these tests pass.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              timour Timour Katchaounov added a comment -

              In order for the following test cases to pass:
              perfschema.binlog_mix perfschema.binlog_row perfschema.binlog_stmt

              We need to backport:
              revno: 4559
              committer: Marc Alff <marc.alff@oracle.com>
              branch nick: mysql-5.6-bug14741537-v4
              timestamp: Thu 2012-11-08 22:40:31 +0100
              message:
              Bug#14741537 - MYSQL 5.6, GTID AND PERFORMANCE_SCHEMA

              Currently in progress.

              Show
              timour Timour Katchaounov added a comment - In order for the following test cases to pass: perfschema.binlog_mix perfschema.binlog_row perfschema.binlog_stmt We need to backport: revno: 4559 committer: Marc Alff <marc.alff@oracle.com> branch nick: mysql-5.6-bug14741537-v4 timestamp: Thu 2012-11-08 22:40:31 +0100 message: Bug#14741537 - MYSQL 5.6, GTID AND PERFORMANCE_SCHEMA Currently in progress.
              Hide
              timour Timour Katchaounov added a comment - - edited

              In order to reuse MySQL's version of perfschema.privilege (and the related privilege.inc), it is necessary to backport the following patch. I don't think this is a priority ATM.

              ------------------------------------------------------------
              revno: 3690.34.61
              committer: Nisha Gopalakrishnan <nisha.gopalakrishnan@oracle.com>
              branch nick: mysql-trunk-13840553_2
              timestamp: Thu 2012-06-07 09:12:57 +0530
              message:
              Bug#13840553:64617: MYSQL MUST IMPROVE ERROR MESSAGES

              Analysis
              --------
              When an ALTER TABLE operation is performed with an invalid foreign key
              constraint, the error reported is ER_CANT_CREATE_TABLE(Cannot create
              the table). The ALTER TABLE operation is performed on a copy of the
              original table, the original table is later deleted and the copy is
              renamed to the original table name. The error reported contains the
              temporary table name which is of the format
              'database_ name.#sql-[0-9_a-f-]*'.

              Fix:

              print_error() which maps the handler error to a SQL error has been used
              to report the error. This has helped in reporting more specific errors
              instead of the previously reported generic error ER_CANT_CREATE_TABLE
              (Cannot create the table) in most of the error scenarios. For the case
              of invalid foreign key constraint, the error that will be reported is:
              ER_CANNOT_ADD_FOREIGN- Cannot add foreign key constraint.

              Show
              timour Timour Katchaounov added a comment - - edited In order to reuse MySQL's version of perfschema.privilege (and the related privilege.inc), it is necessary to backport the following patch. I don't think this is a priority ATM. ------------------------------------------------------------ revno: 3690.34.61 committer: Nisha Gopalakrishnan <nisha.gopalakrishnan@oracle.com> branch nick: mysql-trunk-13840553_2 timestamp: Thu 2012-06-07 09:12:57 +0530 message: Bug#13840553:64617: MYSQL MUST IMPROVE ERROR MESSAGES Analysis -------- When an ALTER TABLE operation is performed with an invalid foreign key constraint, the error reported is ER_CANT_CREATE_TABLE(Cannot create the table). The ALTER TABLE operation is performed on a copy of the original table, the original table is later deleted and the copy is renamed to the original table name. The error reported contains the temporary table name which is of the format 'database_ name.#sql- [0-9_a-f-] *'. Fix: — print_error() which maps the handler error to a SQL error has been used to report the error. This has helped in reporting more specific errors instead of the previously reported generic error ER_CANT_CREATE_TABLE (Cannot create the table) in most of the error scenarios. For the case of invalid foreign key constraint, the error that will be reported is: ER_CANNOT_ADD_FOREIGN- Cannot add foreign key constraint.
              Hide
              timour Timour Katchaounov added a comment -

              It turns out that there is an additional PFS-related test suite - perfschema_stress, that needs to be merged.

              Show
              timour Timour Katchaounov added a comment - It turns out that there is an additional PFS-related test suite - perfschema_stress, that needs to be merged.
              Hide
              timour Timour Katchaounov added a comment -

              It seems that perfschema_stress is abandoned, because the suite doesn't pass even in mysql 5.7.

              Show
              timour Timour Katchaounov added a comment - It seems that perfschema_stress is abandoned, because the suite doesn't pass even in mysql 5.7.
              Hide
              timour Timour Katchaounov added a comment -

              checked marc's commits from the top of the 5.6.10 log to r4122.

              Show
              timour Timour Katchaounov added a comment - checked marc's commits from the top of the 5.6.10 log to r4122.
              Hide
              timour Timour Katchaounov added a comment -

              Agreed with Serg that it doesn't make sense to check the remaining patches, because all tests cases are merged anyway.

              Show
              timour Timour Katchaounov added a comment - Agreed with Serg that it doesn't make sense to check the remaining patches, because all tests cases are merged anyway.

                People

                • Assignee:
                  timour Timour Katchaounov
                  Reporter:
                  timour Timour Katchaounov
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Due:
                    Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - 1 week, 2 days
                    1w 2d
                    Remaining:
                    Time Spent - 4 days, 3 hours Remaining Estimate - 2 days, 5 hours
                    2d 5h
                    Logged:
                    Time Spent - 4 days, 3 hours Remaining Estimate - 2 days, 5 hours
                    4d 3h