Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 10.0.3, 5.5.31
-
Fix Version/s: 10.0.5
-
Component/s: None
-
Labels:None
-
Environment:All
Description
Currently several places use description_event->common_header_len instead of LOG_EVENT_MINIMAL_HEADER_LEN when parsing events with "frozen" headers (such as Start_event_v3 and its subclasses such as Format_description_log_event, as well as Rotate_event). This causes events with extra headers (which would otherwise be valid and those headers ignored) to be corrupted due to over-reading or skipping into the data portion of the log events.
Patch is forthcoming.
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Sergei Golubchik: The patches attached to this ticket (mdev_4645.patch, mdev_4645_2.patch, mdev_4645_3.patch) are provided under the "New BSD" License by Google Inc.
Attaching mdev_4645_3.patch which fixes a related issue where the Format_description_log_event event's common_header_len field would be overwritten by the slave's LOG_EVENT_HEADER_LEN value rather than preserving the common_header_len received in the original event.
Committed for review (with some fixes).
Variant with test suite committed for review.
pushed to 10.0-base
The attached patch addresses the following:
H/-hexdump produces output. The new structure formats better (more closely to hexdump -C) without alignment errors, and with easier to visually parse fields. Additionally it is more extensible, allowing for downstream users (i.e. me) to parse additional header information with simpler patches.H/-hexdump handles headers of variable lengths (as above) correctly.