Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4549

[PATCH] Clean up code working with ACL tables

        Details

        • Type: Task
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Fix Version/s: 10.1.0
        • Component/s: None
        • Labels:
          None

          Description

          Please consider including the attached patch into MariaDB.
          It cleans up the code in sql/sql_acl.cc so that it usess enum values to index different ACL tables instead of hard-coded numbers as indexes. This makes the code more understandable for the reader and less prone to errors during merges between independent changes.

            Gliffy Diagrams

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                serg Sergei Golubchik added a comment -

                Sergey Vojtovich, could you please review this cleanup patch? Thanks.

                Show
                serg Sergei Golubchik added a comment - Sergey Vojtovich , could you please review this cleanup patch? Thanks.
                Hide
                Permalink
                svoj Sergey Vojtovich added a comment -

                Ok to push.

                Show
                svoj Sergey Vojtovich added a comment - Ok to push.

                  People

                  • Assignee:
                    serg Sergei Golubchik
                    Reporter:
                    pivanof Pavel Ivanov
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Time Tracking

                      Estimated:
                      Original Estimate - 3 hours
                      3h
                      Remaining:
                      Time Spent - 2 hours Remaining Estimate - 1 hour
                      1h
                      Logged:
                      Time Spent - 2 hours Remaining Estimate - 1 hour
                      2h