Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4234

[PATCH] MTR testing framework leaves temporary files behind

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Not a Bug
    • Affects Version/s: 10.0.1
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      MTR testing framework leaves temporary files on the disk every time it has to use *.rdiff files. The following patch fixes that:

      --- a/mysql-test/mysql-test-run.pl
      +++ b/mysql-test/mysql-test-run.pl
      @@ -4345,6 +4345,11 @@ sub run_testcase ($$) {
           {
             my $res= $test->exit_status();
       
      +      if ($tinfo->{'result_file'} && ($tinfo->{'result_file'} =~ /\.result~$/))
      +      {
      +        unlink $tinfo->{'result_file'};
      +      }
      +
             if ($res == 0 and $opt_warnings and check_warnings($tinfo) )
             {
              # Test case suceeded, but it has produced unexpected
      

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            serg Sergei Golubchik added a comment -

            It's a feature, not a bug. These files cache the result of patching. They're intentionally named to match "*" glob, because bzr ignores there files. And - see elsewhere - mtr checks the timestamp of the rdiff file and a timestamp of the .result file and regenerates the latter as necessary.

            Show
            serg Sergei Golubchik added a comment - It's a feature, not a bug. These files cache the result of patching. They're intentionally named to match "* " glob, because bzr ignores there files. And - see elsewhere - mtr checks the timestamp of the rdiff file and a timestamp of the .result file and regenerates the latter as necessary.

              People

              • Assignee:
                serg Sergei Golubchik
                Reporter:
                pivanof Pavel Ivanov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: