Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4225

Possible bug in JOIN_CACHE::get_min_join_buffer_size()

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 10.0.1, 5.5.29, 5.3.12
        • Fix Version/s: 10.0.2, 5.5.31, 5.3.13
        • Component/s: None
        • Labels:
          None

          Description

          10.0.1 tarball has very suspicious code in sql/sql_join_cache.cc line 777:

                len+= tab->get_max_used_fieldlength();
      len_last=+ tab->get_used_fieldlength();

          Note that on the second line '+' is after '='. Looking at the surroundings it seems that '+' was supposed to be before '='. Please check if it's a bug.

            Gliffy Diagrams

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                pivanof Pavel Ivanov added a comment -

                Sorry, jira formatter ate away '+' symbols in the description and I can't edit to fix it.

                Show
                pivanof Pavel Ivanov added a comment - Sorry, jira formatter ate away '+' symbols in the description and I can't edit to fix it.
                Hide
                Permalink
                elenst Elena Stepanova added a comment -

                I've kept the priority as initially set by reporter, please adjust if needed.

                Show
                elenst Elena Stepanova added a comment - I've kept the priority as initially set by reporter, please adjust if needed.
                Hide
                Permalink
                elenst Elena Stepanova added a comment -

                I saw on IRC that Wlad was going to fix this (and confirmed with Igor), so reassigning accordingly.

                Show
                elenst Elena Stepanova added a comment - I saw on IRC that Wlad was going to fix this (and confirmed with Igor), so reassigning accordingly.
                Hide
                Permalink
                wlad Vladislav Vaintroub added a comment -

                pushed to 5.3

                Show
                wlad Vladislav Vaintroub added a comment - pushed to 5.3

                  People

                  • Assignee:
                    wlad Vladislav Vaintroub
                    Reporter:
                    pivanof Pavel Ivanov
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - 0 minutes
                      0m
                      Logged:
                      Time Spent - 1 hour
                      1h