Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-420

extend my_gethwaddr on linux to see disabled interfaces

    Details

    • Type: Task
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Fix Version/s: 10.0
    • Component/s: None
    • Labels:
      None

      Description

      currently my_gethwaddr on linux uses SIOCGIFHWADDR to list all interfaces. That only shows interfaces that are UP.

      For my_gethwaddr it is absolutely unnecessary limitation. It needs any mac address of any interface. This limitation causes it to fail on systems that have all interfaces disabled for some reason (or only virtual interfaces are UP - in certain virtual machines).

      It'd be better to change my_gethwaddr to examine all interfaces, UP or DOWN.

      A relatively easy way of doing it would be to read /sys/class/net/*/address files.

      Once this is fixed, it should be checked if the following three suppressions
      can be removed from @antipatterns in mysql-test-run.pl:

           qr|feedback plugin: failed to retrieve the MAC address|,
           qr|Plugin 'FEEDBACK' init function returned error|,
           qr|Plugin 'FEEDBACK' registration as a INFORMATION SCHEMA failed|,
      

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            knielsen Kristian Nielsen added a comment -

            For now, I added suppressions to the resulting errors/warnings in the error log, so we can get a green buildbot.

            These should probably be removed again as part of this fix.

            Show
            knielsen Kristian Nielsen added a comment - For now, I added suppressions to the resulting errors/warnings in the error log, so we can get a green buildbot. These should probably be removed again as part of this fix.

              People

              • Assignee:
                Unassigned
                Reporter:
                serg Sergei Golubchik
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 2 days
                  2d
                  Remaining:
                  Remaining Estimate - 2 days
                  2d
                  Logged:
                  Time Spent - Not Specified
                  Not Specified