Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 5.5.29
-
Fix Version/s: 5.5.30
-
Component/s: None
-
Labels:None
-
Environment:OpenBSD
Description
The thread pool code within MariaDB 5.5 and other newer/older releases fails to build on OpenBSD / NetBSD / DragonFly, etc. These other *BSD OS's also have kqueue support. The attached patch adds the other *BSD OS's to the #if def's within the code to make the code build.
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Duhh. Of course that is the better approach 
I will check this out with OpenBSD and get back to you.
This builds fine.
Also does it make sense to have the #error directive at the top and one further down? One of them should be good enough and the one near the top is more visible when you first open the file in an editor.
Thanks.
Yes, you're right about #error . I now left just one on top, removed second. Thanks.
Brad,
.I have just OSX and FreeBSD, so I do not know if this will 100% work on all others.
Could you check if this patch http://bazaar.launchpad.net/~maria-captains/maria/5.5-wlad/revision/3662 satisfies needs on those platforms . It is basically yours, just that complicate preprocessor expression is replaced with system check (the preprocessor contant check grew a bit too large listing all BSD variants
Thanks!