Details
Minor
Description
storage_engine tests and upstream engines/* suites went out of sync with current MariaDB code. Reasons:
- as of 5.5.27, YEAR(2) is deprecated, hence the new warning;
MDEV-533- different error code/message on out-of-range auto-increment;- INSERT IGNORE now produces a warning if a duplicate key was encountered (change pushed along with
MDEV-533).
Result files need to be updated. For MDEV-533, also test files which expect a different error code need to be modified.
Gliffy Diagrams
Attachments
Issue Links
- relates to
-
MDEV-3942 FROM_DAYS(<timestamp column>) returns different result in MariaDB comparing to MySQL: NULL vs 0000-00-00
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Hi Sergei,
Here is the 10.0 part (on top of the previous change):
http://bazaar.launchpad.net/~elenst/maria/10.0-base-mdev3990/revision/3468
I listed sources of the differences, as much as I could identify them, in the commit comment.
Everything, but the insert_time.result is certainly ok.
changes in the insert_time.result look plausible too, but I didn't track every 00:00:00 change back to its origin, incorrectly formatted time.
What I did was take this test:
create table t1 (c1 time);
insert into t1 values ('00:00:00');
select * from t1 where c1 >='12colon34colon56';
c1
00:00:00
Warnings:
Warning 1292 Truncated incorrect time value: '12colon34colon56'
And ran it before and after MDEV-457 fix. Before it was returning the value, after it wasn't – so I figured it's related to that change. MySQL doesn't return a value either, so at least it's consistent.
My understanding is this:
'12colon34colon56' is truncated to '12' and considered to be '00:00:12';
so, everything less than that (up to and including '00:00:11' in that test) is filtered out, and the rest is included in the result set.
ok to push in 10.0-base
pushed into 10.0-base
Hi Sergei,
Here is the patch: http://bazaar.launchpad.net/~elenst/maria/5.5-engines-tests/revision/3605
No harm is done, it's only tests and results in suites which are not a part of the standard set. Is it okay to push into 5.5?