Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-3862

Lift limitation for merging VIEWS with Subqueries in SELECT_LIST and test it

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 10.0.2
    • Component/s: None
    • Labels:
      None

      Description

      Also see http://ru-mysql.livejournal.com/287623.html?nojs=1

      Patch is like this (+ variable to control)

      bell@desktop:~/maria/bzr/work-maria-5.5-test/mysql-test$ bzr diff
      === modified file 'sql/sql_lex.cc'
      — sql/sql_lex.cc 2012-08-27 16:13:17 +0000
      +++ sql/sql_lex.cc 2012-11-16 09:48:33 +0000
      @@ -2578,6 +2578,7 @@ bool LEX::can_be_merged()
      if (tmp_unit->first_select()->parent_lex == this &&
      (tmp_unit->item == 0 ||
      (tmp_unit->item->place() != IN_WHERE &&
      + tmp_unit->item->place() != SELECT_LIST &&
      tmp_unit->item->place() != IN_ON)))
      {
      selects_allow_merge= 0;

      then use random Query Generator to test it.

        Gliffy Diagrams

          Activity

          Hide
          sanja Oleksandr Byelkin added a comment -

          Looking on test cases and manual it looks like test for merge was mixed with test for updateability in this case.

          Show
          sanja Oleksandr Byelkin added a comment - Looking on test cases and manual it looks like test for merge was mixed with test for updateability in this case.
          Hide
          sanja Oleksandr Byelkin added a comment -

          pushed

          Show
          sanja Oleksandr Byelkin added a comment - pushed

            People

            • Assignee:
              sanja Oleksandr Byelkin
              Reporter:
              sanja Oleksandr Byelkin
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 3 days
                3d
                Remaining:
                Remaining Estimate - 2 days, 4 hours
                2d 4h
                Logged:
                Time Spent - Not Specified Time Not Required
                Not Specified