[MDEV-3790] LP:712720 - handlersocket does not compile against MariaDB 5.3 - JIRA

Details

Type: Task
Status: Closed
Priority: Minor
Resolution: Fixed
Fix Version/s: None
Component/s: None
Labels:
- Launchpad
- MariaDB_5.3

Description

Even after working around bug 712714 , handlersocket does not compile against maria-5.3

To repeat, configure handlersocket

./configure --with-mysql-source=/home/philips/bzr/mysql-5.3.0-MariaDB-alpha --with-mysql-bindir=/home/philips/bzr/maria-5.3-bintar/bin/

then run "make" and you will get

/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h: In member function ‘void dena::dbcontext::cmd_find_internal(dena::dbcallback_i&, const dena::prep_stmt&, ha_rkey_function, const dena::cmd_exec_args&)’:
/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1805: error: ‘virtual int handler::index_read_map(uchar*, const uchar*, key_part_map, ha_rkey_function)’ is protected
database.cpp:793: error: within this context
/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1823: error: ‘virtual int handler::index_prev(uchar*)’ is protected
database.cpp:798: error: within this context
/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1821: error: ‘virtual int handler::index_next(uchar*)’ is protected
database.cpp:802: error: within this context
/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1829: error: ‘virtual int handler::index_next_same(uchar*, const uchar*, uint)’ is protected
database.cpp:805: error: within this context
make[2]: *** [handlersocket_la-database.lo] Error 1

Gliffy Diagrams

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

LPexportBug712720_handlersocket.diff
5 kB
2011-02-08 09:34
LPexportBug712720.xml
14 kB
2012-10-03 11:32

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Sergei Golubchik added a comment - 2011-02-03 21:11

Re: [Bug 712720] [NEW] handlersocket does not compile against MariaDB 5.3
Hi, Philip!

we have a plug.in file for handlersocket that allows to build it from
within the source tree. It solves this problem.

On Feb 03, Philip Stoev wrote:
> Public bug reported:
>
> Even after working around bug 712714 , handlersocket does not compile
> against maria-5.3
>
> To repeat, configure handlersocket
>
> ./configure -~~with-mysql-source=/home/philips/bzr/mysql-5.3.0-MariaDB~~
> alpha --with-mysql-bindir=/home/philips/bzr/maria-5.3-bintar/bin/
>
> then run "make" and you will get
>
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h: In member function ?void dena::dbcontext::cmd_find_internal(dena::dbcallback_i&, const dena::prep_stmt&, ha_rkey_function, const dena::cmd_exec_args&)?:
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1805: error: ?virtual int handler::index_read_map(uchar*, const uchar*, key_part_map, ha_rkey_function)? is protected
> database.cpp:793: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1823: error: ?virtual int handler::index_prev(uchar*)? is protected
> database.cpp:798: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1821: error: ?virtual int handler::index_next(uchar*)? is protected
> database.cpp:802: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1829: error: ?virtual int handler::index_next_same(uchar*, const uchar*, uint)? is protected
> database.cpp:805: error: within this context
> make[2]: *** [handlersocket_la-database.lo] Error 1
>
> ** Affects: maria
> Importance: Undecided
> Status: New
>
> ** Changed in: maria
> Milestone: None => 5.3
>
> ** Branch linked: lp:~maria-captains/maria/5.3-handler
>
> –
> You received this bug notification because you are a member of Maria-
> captains, which is the registrant for Maria.
> https://bugs.launchpad.net/bugs/712720
>
> Title:
> handlersocket does not compile against MariaDB 5.3
>
> Status in Maria:
> New
>
> Bug description:
> Even after working around bug 712714 , handlersocket does not compile
> against maria-5.3
>
> To repeat, configure handlersocket
>
> ./configure --with-mysql-source=/home/philips/bzr/mysql-5.3.0
> ~~MariaDB-alpha --with-mysql~~
> bindir=/home/philips/bzr/maria-5.3-bintar/bin/
>
> then run "make" and you will get
>
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h: In member function ?void dena::dbcontext::cmd_find_internal(dena::dbcallback_i&, const dena::prep_stmt&, ha_rkey_function, const dena::cmd_exec_args&)?:
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1805: error: ?virtual int handler::index_read_map(uchar*, const uchar*, key_part_map, ha_rkey_function)? is protected
> database.cpp:793: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1823: error: ?virtual int handler::index_prev(uchar*)? is protected
> database.cpp:798: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1821: error: ?virtual int handler::index_next(uchar*)? is protected
> database.cpp:802: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1829: error: ?virtual int handler::index_next_same(uchar*, const uchar*, uint)? is protected
> database.cpp:805: error: within this context
> make[2]: *** [handlersocket_la-database.lo] Error 1
>
>
>
Regards,
Sergei

Show

Sergei Golubchik added a comment - 2011-02-03 21:11 Re: [Bug 712720] [NEW] handlersocket does not compile against MariaDB 5.3 Hi, Philip! we have a plug.in file for handlersocket that allows to build it from within the source tree. It solves this problem. On Feb 03, Philip Stoev wrote: > Public bug reported: > > Even after working around bug 712714 , handlersocket does not compile > against maria-5.3 > > To repeat, configure handlersocket > > ./configure - with-mysql-source=/home/philips/bzr/mysql-5.3.0-MariaDB > alpha --with-mysql-bindir=/home/philips/bzr/maria-5.3-bintar/bin/ > > then run "make" and you will get > > /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h: In member function ? void dena::dbcontext::cmd_find_internal(dena::dbcallback_i&, const dena::prep_stmt&, ha_rkey_function, const dena::cmd_exec_args&) ?: > /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1805: error: ? virtual int handler::index_read_map(uchar*, const uchar*, key_part_map, ha_rkey_function) ? is protected > database.cpp:793: error: within this context > /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1823: error: ? virtual int handler::index_prev(uchar*) ? is protected > database.cpp:798: error: within this context > /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1821: error: ? virtual int handler::index_next(uchar*) ? is protected > database.cpp:802: error: within this context > /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1829: error: ? virtual int handler::index_next_same(uchar*, const uchar*, uint) ? is protected > database.cpp:805: error: within this context > make [2] : *** [handlersocket_la-database.lo] Error 1 > > ** Affects: maria > Importance: Undecided > Status: New > > ** Changed in: maria > Milestone: None => 5.3 > > ** Branch linked: lp:~maria-captains/maria/5.3-handler > > – > You received this bug notification because you are a member of Maria- > captains, which is the registrant for Maria. > https://bugs.launchpad.net/bugs/712720 > > Title: > handlersocket does not compile against MariaDB 5.3 > > Status in Maria: > New > > Bug description: > Even after working around bug 712714 , handlersocket does not compile > against maria-5.3 > > To repeat, configure handlersocket > > ./configure --with-mysql-source=/home/philips/bzr/mysql-5.3.0 > MariaDB-alpha --with-mysql > bindir=/home/philips/bzr/maria-5.3-bintar/bin/ > > then run "make" and you will get > > /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h: In member function ? void dena::dbcontext::cmd_find_internal(dena::dbcallback_i&, const dena::prep_stmt&, ha_rkey_function, const dena::cmd_exec_args&) ?: > /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1805: error: ? virtual int handler::index_read_map(uchar*, const uchar*, key_part_map, ha_rkey_function) ? is protected > database.cpp:793: error: within this context > /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1823: error: ? virtual int handler::index_prev(uchar*) ? is protected > database.cpp:798: error: within this context > /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1821: error: ? virtual int handler::index_next(uchar*) ? is protected > database.cpp:802: error: within this context > /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1829: error: ? virtual int handler::index_next_same(uchar*, const uchar*, uint) ? is protected > database.cpp:805: error: within this context > make [2] : *** [handlersocket_la-database.lo] Error 1 > > > Regards, Sergei

4 older comments

Hide

Permalink

Philip Stoev added a comment - 2011-02-11 11:08

Re: handlersocket does not compile against MariaDB 5.3
nevermind it worked with -p2

Show

Philip Stoev added a comment - 2011-02-11 11:08 Re: handlersocket does not compile against MariaDB 5.3 nevermind it worked with -p2

Hide

Permalink

Philip Stoev added a comment - 2011-02-11 12:42

Re: handlersocket does not compile against MariaDB 5.3
If -Werror is enabled, as it is by the ./BUILD/compile-pentium-debug-max-no-ndb script, we get:

(13:29:42) philip_stoev1: "cc1plus: warnings being treated as errors
(13:29:42) philip_stoev1: In file included from socket.hpp:15,
(13:29:42) philip_stoev1: from socket.cpp:18:
(13:29:42) philip_stoev1: auto_addrinfo.hpp: In member function ‘int dena::auto_addrinfo::resolve(const char*, const char*, int, int, int, int)’:
(13:29:42) philip_stoev1: auto_addrinfo.hpp:35: error: missing initializer for member ‘addrinfo::ai_flags’"

Show

Philip Stoev added a comment - 2011-02-11 12:42 Re: handlersocket does not compile against MariaDB 5.3 If -Werror is enabled, as it is by the ./BUILD/compile-pentium-debug-max-no-ndb script, we get: (13:29:42) philip_stoev1: "cc1plus: warnings being treated as errors (13:29:42) philip_stoev1: In file included from socket.hpp:15, (13:29:42) philip_stoev1: from socket.cpp:18: (13:29:42) philip_stoev1: auto_addrinfo.hpp: In member function ‘int dena::auto_addrinfo::resolve(const char*, const char*, int, int, int, int)’: (13:29:42) philip_stoev1: auto_addrinfo.hpp:35: error: missing initializer for member ‘addrinfo::ai_flags’"

Hide

Permalink

Rasmus Johansson added a comment - 2011-04-18 09:31

Re: handlersocket does not compile against MariaDB 5.3
Hi,

Where can I find the plug.in file and instructions on how to patch it. I'm trying to build it against mariadb 5.2.5 and I am receiving the same error.

Thanks

Show

Rasmus Johansson added a comment - 2011-04-18 09:31 Re: handlersocket does not compile against MariaDB 5.3 Hi, Where can I find the plug.in file and instructions on how to patch it. I'm trying to build it against mariadb 5.2.5 and I am receiving the same error. Thanks

Hide

Permalink

Sergei Golubchik added a comment - 2011-04-18 17:39

Re: [Bug 712720] Re: handlersocket does not compile against MariaDB 5.3
Hi, Jason!

On Apr 18, Jason wrote:
> Hi,
>
> Where can I find the plug.in file and instructions on how to patch it.
> I'm trying to build it against mariadb 5.2.5 and I am receiving the same
> error.

See, the bug report has "Status: Fix Committed", and "Milestone: Maria 5.3".
Which means, you can find the files in 5.3 mariadb tree.

http://bazaar.launchpad.net/~maria-captains/maria/5.3/files

Regards,
Sergei

Show

Sergei Golubchik added a comment - 2011-04-18 17:39 Re: [Bug 712720] Re: handlersocket does not compile against MariaDB 5.3 Hi, Jason! On Apr 18, Jason wrote: > Hi, > > Where can I find the plug.in file and instructions on how to patch it. > I'm trying to build it against mariadb 5.2.5 and I am receiving the same > error. See, the bug report has "Status: Fix Committed", and "Milestone: Maria 5.3". Which means, you can find the files in 5.3 mariadb tree. http://bazaar.launchpad.net/~maria-captains/maria/5.3/files Regards, Sergei

Hide

Permalink

Rasmus Johansson added a comment - 2011-05-10 23:14

Launchpad bug id: 712720

Show

Rasmus Johansson added a comment - 2011-05-10 23:14 Launchpad bug id: 712720

LP:712720 - handlersocket does not compile against MariaDB 5.3

Details

Description

Gliffy Diagrams

Attachments

Attachments

Activity

People

Dates

Agile