Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-3714

LP:635633 - OQGRAPH is silently not compiled if boost is missing

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      OQGRAPH is silently not compiled if boost is missing – configure mentions the fact in passing and proceeds to compile a binary. Instead, ./configure should have failed.

      Silent non-compilation of engines and features has been a historic problem for MySQL – the MTR test suite does not detect such omissions and simply skips the relevant tests, which requires extra scripts and work at build time to verify that the binary contains all desired features. Explicit ./configure failures are much easier to detect.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            serg Sergei Golubchik added a comment -

            Re: [Bug 635633] [NEW] OQGRAPH is silently not compiled if boost is missing
            Hi, Philip!

            I suppose you want

            ./configure --with-plugin-oqgraph

            to fail if oqgraph is not built, but plain

            ./configure

            should not fail.

            On Sep 11, Philip Stoev wrote:
            >
            > Public bug reported:
            >
            > OQGRAPH is silently not compiled if boost is missing – configure
            > mentions the fact in passing and proceeds to compile a binary. Instead,
            > ./configure should have failed.
            >
            > Silent non-compilation of engines and features has been a historic
            > problem for MySQL – the MTR test suite does not detect such omissions
            > and simply skips the relevant tests, which requires extra scripts and
            > work at build time to verify that the binary contains all desired
            > features. Explicit ./configure failures are much easier to detect.
            >
            > ** Affects: maria
            > Importance: Undecided
            > Assignee: Sergei (sergii)
            > Status: New
            >
            >
            > ** Tags: oqgraph
            >
            > ** Changed in: maria
            > Milestone: None => 5.2
            >
            > ** Changed in: maria
            > Assignee: (unassigned) => Sergei (sergii)
            >
            > –
            > OQGRAPH is silently not compiled if boost is missing
            > https://bugs.launchpad.net/bugs/635633
            > You received this bug notification because you are a member of Maria-
            > captains, which is the registrant for Maria.
            >
            > Status in Maria: New
            >
            > Bug description:
            > OQGRAPH is silently not compiled if boost is missing – configure mentions the fact in passing and proceeds to compile a binary. Instead, ./configure should have failed.
            >
            > Silent non-compilation of engines and features has been a historic problem for MySQL – the MTR test suite does not detect such omissions and simply skips the relevant tests, which requires extra scripts and work at build time to verify that the binary contains all desired features. Explicit ./configure failures are much easier to detect.
            >
            >
            >
            Regards,
            Sergei

            Show
            serg Sergei Golubchik added a comment - Re: [Bug 635633] [NEW] OQGRAPH is silently not compiled if boost is missing Hi, Philip! I suppose you want ./configure --with-plugin-oqgraph to fail if oqgraph is not built, but plain ./configure should not fail. On Sep 11, Philip Stoev wrote: > > Public bug reported: > > OQGRAPH is silently not compiled if boost is missing – configure > mentions the fact in passing and proceeds to compile a binary. Instead, > ./configure should have failed. > > Silent non-compilation of engines and features has been a historic > problem for MySQL – the MTR test suite does not detect such omissions > and simply skips the relevant tests, which requires extra scripts and > work at build time to verify that the binary contains all desired > features. Explicit ./configure failures are much easier to detect. > > ** Affects: maria > Importance: Undecided > Assignee: Sergei (sergii) > Status: New > > > ** Tags: oqgraph > > ** Changed in: maria > Milestone: None => 5.2 > > ** Changed in: maria > Assignee: (unassigned) => Sergei (sergii) > > – > OQGRAPH is silently not compiled if boost is missing > https://bugs.launchpad.net/bugs/635633 > You received this bug notification because you are a member of Maria- > captains, which is the registrant for Maria. > > Status in Maria: New > > Bug description: > OQGRAPH is silently not compiled if boost is missing – configure mentions the fact in passing and proceeds to compile a binary. Instead, ./configure should have failed. > > Silent non-compilation of engines and features has been a historic problem for MySQL – the MTR test suite does not detect such omissions and simply skips the relevant tests, which requires extra scripts and work at build time to verify that the binary contains all desired features. Explicit ./configure failures are much easier to detect. > > > Regards, Sergei
            Hide
            philipstoev Philip Stoev added a comment -

            Re: OQGRAPH is silently not compiled if boost is missing
            Yes exactly.

            Show
            philipstoev Philip Stoev added a comment - Re: OQGRAPH is silently not compiled if boost is missing Yes exactly.
            Hide
            ratzpo Rasmus Johansson added a comment -

            Launchpad bug id: 635633

            Show
            ratzpo Rasmus Johansson added a comment - Launchpad bug id: 635633

              People

              • Assignee:
                serg Sergei Golubchik
                Reporter:
                philipstoev Philip Stoev
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: