Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-3693

LP:612832 - MariaDB Won't Compile in Cygwin - Patch Attached

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Simple issue in the command line tools. MySQL claims they don't officially support Cygwin and closed the bug, even though there are hundreds of #ifdef's referencing Cygwin already. Bah!

      — vi.c.orig 2010-07-31 08:31:06.047354500 -0400
      +++ vi.c 2010-07-31 08:29:42.095897000 -0400
      @@ -914,14 +914,14 @@

      • NB: posix implies that we should enter insert mode, however
      • this is against historical precedent...
        */
        -#if defined(_weak_reference) && !defined(FreeBSD_)
        +#if defined(_weak_reference) && !defined(FreeBSD) && !defined(CYGWIN_)
        extern char *get_alias_text(const char *) __weak_reference(get_alias_text);
        #endif
        protected el_action_t
        /ARGSUSED/
        vi_alias(EditLine *el, int c)
        {
        -#if defined(_weak_reference) && !defined(FreeBSD_)
        +#if defined(_weak_reference) && !defined(FreeBSD) && !defined(CYGWIN_)
        char alias_name[3];
        char *alias_text;

      http://bugs.mysql.com/bug.php?id=55660&error=no

      I don't think I'm being fair.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            bothorsen Bo Thorsen added a comment -

            Re: MariaDB Won't Compile in Cygwin - Patch Attached
            Thanks for the patch, I'll test it and apply. It will take a bit of time, though, as I'm just back from vacation and pretty swamped with work over the next week or so.

            Show
            bothorsen Bo Thorsen added a comment - Re: MariaDB Won't Compile in Cygwin - Patch Attached Thanks for the patch, I'll test it and apply. It will take a bit of time, though, as I'm just back from vacation and pretty swamped with work over the next week or so.
            Hide
            serg Sergei Golubchik added a comment -

            Re: MariaDB Won't Compile in Cygwin - Patch Attached
            what problem does cygwin has with these lines?
            why do you need to add && !defined(_CYGWIN_) ?

            Show
            serg Sergei Golubchik added a comment - Re: MariaDB Won't Compile in Cygwin - Patch Attached what problem does cygwin has with these lines? why do you need to add && !defined(_ CYGWIN _) ?
            Hide
            larryadams Larry Adams added a comment -

            Re: [Bug 612832] Re: MariaDB Won't Compile in Cygwin - Patch Attached
            Sergei,

            I'll send make output. It's behaving identical to FreeBSD though. The
            parameter count it wrong. There are other compile problems too. It's
            related to the new storage engine's. I don't have the details at the
            moment, and am away from my dev environment for the next several days.

            Larry

            On 11/30/2010 11:15 AM, Sergei wrote:
            > what problem does cygwin has with these lines?
            > why do you need to add&& !defined(_CYGWIN_) ?
            >

            Show
            larryadams Larry Adams added a comment - Re: [Bug 612832] Re: MariaDB Won't Compile in Cygwin - Patch Attached Sergei, I'll send make output. It's behaving identical to FreeBSD though. The parameter count it wrong. There are other compile problems too. It's related to the new storage engine's. I don't have the details at the moment, and am away from my dev environment for the next several days. Larry On 11/30/2010 11:15 AM, Sergei wrote: > what problem does cygwin has with these lines? > why do you need to add&& !defined(_ CYGWIN _) ? >
            Hide
            monty Michael Widenius added a comment -

            Re: MariaDB Won't Compile in Cygwin - Patch Attached
            This bug doesn't apply to MariaDB anymore as we never build with the bundled libedit.

            Show
            monty Michael Widenius added a comment - Re: MariaDB Won't Compile in Cygwin - Patch Attached This bug doesn't apply to MariaDB anymore as we never build with the bundled libedit.
            Hide
            ratzpo Rasmus Johansson added a comment -

            Launchpad bug id: 612832

            Show
            ratzpo Rasmus Johansson added a comment - Launchpad bug id: 612832

              People

              • Assignee:
                monty Michael Widenius
                Reporter:
                larryadams Larry Adams
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: