Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-3533

LP:629684 - Unreachable code in multi_range_read.cc in maria-5.3-dsmrr-cpk

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      The code coverage report highlighted the following line from multi_range_read.cc

      720 2322 : if (!*key2) // key1(NULL) < key2(notNULL)
      721 2322 : return -1;
      722 0 : goto equals;
      723 : }

      the "goto equals" part is unreachable , but the equals: label does contain some code.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            psergey Sergei Petrunia added a comment -

            Re: Unreachable code in multi_range_read.cc in maria-5.3-dsmrr-cpk
            Fixed in 5.3-dsmrr-cpk tree.

            Show
            psergey Sergei Petrunia added a comment - Re: Unreachable code in multi_range_read.cc in maria-5.3-dsmrr-cpk Fixed in 5.3-dsmrr-cpk tree.
            Hide
            ratzpo Rasmus Johansson added a comment -

            Launchpad bug id: 629684

            Show
            ratzpo Rasmus Johansson added a comment - Launchpad bug id: 629684

              People

              • Assignee:
                psergey Sergei Petrunia
                Reporter:
                philipstoev Philip Stoev
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: