Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-3502

LP:814238 - safe_mutex issues must be assertions in debug binary

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: None
        • Component/s: None
        • Labels:

          Description

          All safe_mutex warnings must cause assertions in a debug binary. If they are simply reported in the error log with no other indication, they are very difficult to detect in an automatic test.

            Gliffy Diagrams

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                monty Michael Widenius added a comment -

                Re: safe_mutex issues must be assertions in debug binary
                Personally I don't want to have an assert here, as I prefer to get all mutex error warnings collected instead of getting a crash.

                I have however added a new option --debug-assert-on-error, which should be used by automatic tests that wants asserts for things like this.

                Setting this new variable also sets --debug-assert-if-crashed-table.

                Show
                monty Michael Widenius added a comment - Re: safe_mutex issues must be assertions in debug binary Personally I don't want to have an assert here, as I prefer to get all mutex error warnings collected instead of getting a crash. I have however added a new option --debug-assert-on-error, which should be used by automatic tests that wants asserts for things like this. Setting this new variable also sets --debug-assert-if-crashed-table.
                Hide
                Permalink
                ratzpo Rasmus Johansson added a comment -

                Launchpad bug id: 814238

                Show
                ratzpo Rasmus Johansson added a comment - Launchpad bug id: 814238

                  People

                  • Assignee:
                    monty Michael Widenius
                    Reporter:
                    philipstoev Philip Stoev
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: