Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-3483

LP:645830 - Insifficient test coverage for oqgraph

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      It appears that the test coverage provided by the oqgraph MTR suite is not sufficient. Since it was not possible to obtain gcov numbers, the observations below are based on a visual examination of the test suite.

      It appears that the following is missing from the test suite:

      • a complete list of the SELECT statements that are accepted by the engine, as described in
        the manual, including those with latch=0 or latch = NULL;
      • DML and SELECT statements with weight != 0
      • queries that will be rejected by the storage engine, including invalid DDL/ALTER, DML that modifies non-modifiable columns, CREATE TABLE with an invalid layout, etc.
      • an enumeration of the DML/DDL/ALTER statements that are accepted by the engine, so that all the engine capabilities the handler advertises and all the API calls are exercised, including ALTER ENGINE=, INSERT ... SELECT, CREATE .. SELECT etc.
      • verification of each statement after it is executed, e.g. a SELECT must be done after TRUNCATE for a proper test for truncation; an I_S query and CREATE, etc. must be performed after TRUNCATE to test that the table is truly gone, etc.;
      • a dataset that is sized appropriately for MTR execution (10K nodes?). Either in the form of INSERT statements or a stored procedure, plus some SELECT queries on top of that dataset;
      • joins and other cross-engine operations;

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            philipstoev Philip Stoev added a comment -

            I am attaching the coverage files for oqgraph. Lines marked with #### are not covered.
            Coverage files for oqgraph
            LPexportBug645830_oqgraph-coverage.zip

            Show
            philipstoev Philip Stoev added a comment - I am attaching the coverage files for oqgraph. Lines marked with #### are not covered. Coverage files for oqgraph LPexportBug645830_oqgraph-coverage.zip
            Hide
            philipstoev Philip Stoev added a comment -

            Re: Insifficient test coverage for oqgraph
            I am attaching the coverage files for oqgraph. Lines marked with #### are not covered.

            Show
            philipstoev Philip Stoev added a comment - Re: Insifficient test coverage for oqgraph I am attaching the coverage files for oqgraph. Lines marked with #### are not covered.
            Hide
            arjenlentz Arjen Lentz added a comment -

            Re: Insifficient test coverage for oqgraph
            Created two simple data generators:

            • examples/randoms/randtree which can create a simple unidirectional tree structure (like a menu tree)
            • examples/randoms/randsocial can create a social network with friends/weight and fans
              both can be specific at arbitrary size, with variable # of friends and fans, and random weight within a range.
              This should enable more stringent testing of some aspects.

            (present in oqgraph/trunk)

            Show
            arjenlentz Arjen Lentz added a comment - Re: Insifficient test coverage for oqgraph Created two simple data generators: examples/randoms/randtree which can create a simple unidirectional tree structure (like a menu tree) examples/randoms/randsocial can create a social network with friends/weight and fans both can be specific at arbitrary size, with variable # of friends and fans, and random weight within a range. This should enable more stringent testing of some aspects. (present in oqgraph/trunk)
            Hide
            knielsen Kristian Nielsen added a comment -

            Re: Insifficient test coverage for oqgraph
            It's been >1 year with no activity from upstream. There seems little point in keeping this open for mariadb - there are no plans from mariadb project to take over maintenance of OQGraph.

            Show
            knielsen Kristian Nielsen added a comment - Re: Insifficient test coverage for oqgraph It's been >1 year with no activity from upstream. There seems little point in keeping this open for mariadb - there are no plans from mariadb project to take over maintenance of OQGraph.
            Hide
            ratzpo Rasmus Johansson added a comment -

            Launchpad bug id: 645830

            Show
            ratzpo Rasmus Johansson added a comment - Launchpad bug id: 645830

              People

              • Assignee:
                Unassigned
                Reporter:
                philipstoev Philip Stoev
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: