Details
-
Type:
Task
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Fix Version/s: 5.5.27
-
Component/s: None
-
Labels:None
Description
<montywi> the task is the following:
<montywi> If one now do:
<montywi> DROP TABLE /* comment-for-replication */ t1,t2;
<montywi> When we write it to the binary log we remove the comment
<montywi> the task is to preserve the comment between drop table and the first table and write it to the replication log
<montywi> tungsten needs this to be able to know from which server the drop table originated.
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
why this is still in progress and assigned to Alexey Botchkov, if there's a patch proposal? Who is going to review it?
Review done over IRC:
- Suggested fixing comment_length() to use pointers instead of index
- Check for '' after /
- Add test case.
Patch proposal:
http://lists.askmonty.org/pipermail/commits/2012-July/003542.html