Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-3047

LP:943736 - support-files/Makefile.am includes scripts both in pkgsupp_DATA and pkgsupp_SCRIPTS

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      All MariaDB versions since revision 2643.50.1 (but maybe earlier) which use autotools as build system (currently this is the 5.1, 5.2 and 5.3 trees) include the mysql-log-rotate and binary-configure scripts in both the pkgsupp_DATA and the pkgsupp_SCRIPTS variables in support-files/Makefile.am.

      The two files are scripts, so they shouldn't be included in pkgsupp_DATA. The automake documentation mentions that the DATA variables are meant for architecture-independent data files, while the SCRIPTS variables are meant for executable scripts.

      Without the attached patch, the scripts are installed twice on make install.

      http://bazaar.launchpad.net/~maria-captains/maria/5.2/revision/2643.50.1 is various changes by Monty for creation of the official binary builds, including some mention of compatibility symlinks placed in the original location of (presumably) these files.

      Hopefully the scripts to create official builds can be adjusted so that the duplication in pkgsupp_DATA and pkgsupp_SCRIPTS is no longer neccessary.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            peterstuge Peter Stuge added a comment -

            Patch from Gentoo Linux mysql-extras-20110819-0415Z which removes the mysql-log-rotate and binary-configure scripts from pkgsupp_DATA
            LPexportBug943736_16000_all_mariadb_fix_duplicate_install.patch

            Show
            peterstuge Peter Stuge added a comment - Patch from Gentoo Linux mysql-extras-20110819-0415Z which removes the mysql-log-rotate and binary-configure scripts from pkgsupp_DATA LPexportBug943736_16000_all_mariadb_fix_duplicate_install.patch
            Hide
            peterstuge Peter Stuge added a comment -

            Re: support-files/Makefile.am includes scripts both in pkgsupp_DATA and pkgsupp_SCRIPTS

            Show
            peterstuge Peter Stuge added a comment - Re: support-files/Makefile.am includes scripts both in pkgsupp_DATA and pkgsupp_SCRIPTS
            Hide
            serg Sergei Golubchik added a comment -

            Re: support-files/Makefile.am includes scripts both in pkgsupp_DATA and pkgsupp_SCRIPTS
            fixed in 5.5

            Show
            serg Sergei Golubchik added a comment - Re: support-files/Makefile.am includes scripts both in pkgsupp_DATA and pkgsupp_SCRIPTS fixed in 5.5
            Hide
            ratzpo Rasmus Johansson added a comment -

            Launchpad bug id: 943736

            Show
            ratzpo Rasmus Johansson added a comment - Launchpad bug id: 943736

              People

              • Assignee:
                serg Sergei Golubchik
                Reporter:
                peterstuge Peter Stuge
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: