Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-3035

LP:507279 - Compile error on Visual C++ set_var.cc

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      5>.\set_var.cc(1204) : error C2065: 'maria_delay_key_write' : undeclared identifier

      The code in question references a variable that is not in scope. <maria.h> must be included, perhaps conditionally.

      A similar variable, myisam_delay_key_write is in scope, because <myisam.h> is included.

      Including the maria.h fixes the problem.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            alexbudovski Alex Budovski added a comment -

            Re: Compile error on Visual C++ set_var.cc
            Suggested fix:

            === modified file 'sql/set_var.cc'
            — sql/set_var.cc 2009-12-03 11:19:05 +0000
            +++ sql/set_var.cc 2010-01-14 01:25:28 +0000
            @@ -58,6 +58,11 @@
            #include <my_getopt.h>
            #include <thr_alarm.h>
            #include <myisam.h>
            +
            +#ifdef WITH_MARIA_STORAGE_ENGINE
            +#include <maria.h>
            +#endif
            +
            #include <my_dir.h>
            #include <waiting_threads.h>
            #include "events.h"

            Show
            alexbudovski Alex Budovski added a comment - Re: Compile error on Visual C++ set_var.cc Suggested fix: === modified file 'sql/set_var.cc' — sql/set_var.cc 2009-12-03 11:19:05 +0000 +++ sql/set_var.cc 2010-01-14 01:25:28 +0000 @@ -58,6 +58,11 @@ #include <my_getopt.h> #include <thr_alarm.h> #include <myisam.h> + +#ifdef WITH_MARIA_STORAGE_ENGINE +#include <maria.h> +#endif + #include <my_dir.h> #include <waiting_threads.h> #include "events.h"
            Hide
            monty Michael Widenius added a comment -

            [Bug 507279] Re: Compile error on Visual C++ set_var.cc

            Hi!

            >>>>> "Alex" == Alex Budovski <abudovski@gmail.com> writes:

            Alex> Suggested fix:
            Alex> === modified file 'sql/set_var.cc'
            Alex> — sql/set_var.cc 2009-12-03 11:19:05 +0000
            Alex> +++ sql/set_var.cc 2010-01-14 01:25:28 +0000
            Alex> @@ -58,6 +58,11 @@
            Alex> #include <my_getopt.h>
            Alex> #include <thr_alarm.h>
            Alex> #include <myisam.h>
            Alex> +
            Alex> +#ifdef WITH_MARIA_STORAGE_ENGINE
            Alex> +#include <maria.h>
            Alex> +#endif
            Alex> +
            Alex> #include <my_dir.h>
            Alex> #include <waiting_threads.h>
            Alex> #include "events.h"

            Thanks, will do this.

            In the future we will move this variable to ha_maria.cc, but for now
            this is ok.

            Regards,
            Monty

            Show
            monty Michael Widenius added a comment - [Bug 507279] Re: Compile error on Visual C++ set_var.cc Hi! >>>>> "Alex" == Alex Budovski <abudovski@gmail.com> writes: Alex> Suggested fix: Alex> === modified file 'sql/set_var.cc' Alex> — sql/set_var.cc 2009-12-03 11:19:05 +0000 Alex> +++ sql/set_var.cc 2010-01-14 01:25:28 +0000 Alex> @@ -58,6 +58,11 @@ Alex> #include <my_getopt.h> Alex> #include <thr_alarm.h> Alex> #include <myisam.h> Alex> + Alex> +#ifdef WITH_MARIA_STORAGE_ENGINE Alex> +#include <maria.h> Alex> +#endif Alex> + Alex> #include <my_dir.h> Alex> #include <waiting_threads.h> Alex> #include "events.h" Thanks, will do this. In the future we will move this variable to ha_maria.cc, but for now this is ok. Regards, Monty
            Hide
            ratzpo Rasmus Johansson added a comment -

            Launchpad bug id: 507279

            Show
            ratzpo Rasmus Johansson added a comment - Launchpad bug id: 507279

              People

              • Assignee:
                monty Michael Widenius
                Reporter:
                alexbudovski Alex Budovski
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: