Details
-
Type:
Bug
-
Status: Closed
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:
Description
compilation of ma_loghandler.c fails in line 1398, since fd was declared after macro call LINT_INIT_STRUCT()
Suggested fix:
=== modified file 'storage/maria/ma_loghandler.c'
— storage/maria/ma_loghandler.c 2010-03-10 10:32:14 +0000
+++ storage/maria/ma_loghandler.c 2010-03-29 14:45:27 +0000
@@ -1394,8 +1394,9 @@
{
LOGHANDLER_FILE_INFO info;
+ File fd;
LINT_INIT_STRUCT(info);
- File fd= open_logfile_by_number_no_cache(file);
+ fd= open_logfile_by_number_no_cache(file);
if ((fd < 0) ||
(translog_read_file_header(&info, fd) | my_close(fd, MYF(MY_WME))))
{
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Re: Windows compile error in ma_loghandler.c
Sanja and I have fixed the two places where this was seen. And I fixed another windows compilation issue. lp:maria compiles for me on Windows Vista using Visual Studio 2008 now.
Launchpad bug id: 550974
Re: [Bug 550974] [NEW] Windows compile error in ma_loghandler.c
Hi!
29 марта 2010, в 18:51, Georg Richter написал(а):
> Public bug reported:
>
> compilation of ma_loghandler.c fails in line 1398, since fd was
> declared after macro call LINT_INIT_STRUCT()
>
> Suggested fix:
> === modified file 'storage/maria/ma_loghandler.c'
> — storage/maria/ma_loghandler.c 2010-03-10 10:32:14 +0000
> +++ storage/maria/ma_loghandler.c 2010-03-29 14:45:27 +0000
> @@ -1394,8 +1394,9 @@
>
> {
> LOGHANDLER_FILE_INFO info;
> + File fd;
> LINT_INIT_STRUCT(info);
> - File fd= open_logfile_by_number_no_cache(file);
> + fd= open_logfile_by_number_no_cache(file);
> if ((fd < 0) ||
> (translog_read_file_header(&info, fd) | my_close(fd,
> MYF(MY_WME))))
> {
>
Thank you a lot, but I'd better move LINT_INIT_STRUCT(info); lower...