Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-2794

LP:728919 - maria_chk should fail on all detected corruptions

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Now that maria_chk is used for recovery testing, it should have an option to fail with a suitable exit code on all database corruptions. Currently, some are just printed as warnings, such as:

      maria_chk: warning: Found row where the auto_increment column has the value 0

      and are thus not detectable during automatic test runs. The code has the following comment:

      /* Don't count this as a real warning, as maria_chk can't correct it */

      such logic is not true when it comes to automatic recovery testing. There are other instances in the code where the same trick is used to prevent maria_chk from reporting a proper exit code.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            monty Michael Widenius added a comment -

            Re: maria_chk should fail on all detected corruptions
            I am fixing that in 5.2 aria_chk will return 1 if there was any warnings and 2 if there was any fatal errors

            Show
            monty Michael Widenius added a comment - Re: maria_chk should fail on all detected corruptions I am fixing that in 5.2 aria_chk will return 1 if there was any warnings and 2 if there was any fatal errors
            Hide
            ratzpo Rasmus Johansson added a comment -

            Launchpad bug id: 728919

            Show
            ratzpo Rasmus Johansson added a comment - Launchpad bug id: 728919

              People

              • Assignee:
                monty Michael Widenius
                Reporter:
                philipstoev Philip Stoev
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: