Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-2782

LP:600744 - XtraDB compile error with VS 10 64-bit

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Compiling XtraDB with VS 2010 on 64-bit Windows fails with several errors all of the type:

      Error 10 error C2440: 'initializing' : cannot convert from 'ulint *' to 'unsigned long *' C:\Users\hakan\work\monty_program\maria-5.2\storage\xtradb\handler\ha_innodb.cc 10410

      The code in question is:

      Error 10 error C2440: 'initializing' : cannot convert from 'ulint *' to 'unsigned long *' C:\Users\hakan\work\monty_program\maria-5.2\storage\xtradb\handler\ha_innodb.cc 10410

      static MYSQL_SYSVAR_ULONG(use_purge_thread, srv_use_purge_thread,
      PLUGIN_VAR_RQCMDARG | PLUGIN_VAR_READONLY,
      "Number of purge devoted threads. #### over 1 is EXPERIMENTAL ####",
      NULL, NULL, 1, 0, 64, 0);

      And line 10410 is
      NULL, NULL, 1, 0, 64, 0);

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            bothorsen Bo Thorsen added a comment -

            The problem is that xtradb tries to store a ulint using unsigned long. This works on all architecures except 64 bit Windows because ulint is defined as __int64 on that. There is currently no MYSQL_SYSVAR_xx that matches this, so I have added a MYSQL_SYSVAR_ULINT and changed the calls to this. See the attached patch.
            fix-600744.patch
            LPexportBug600744_fix-600744.patch

            Show
            bothorsen Bo Thorsen added a comment - The problem is that xtradb tries to store a ulint using unsigned long. This works on all architecures except 64 bit Windows because ulint is defined as __int64 on that. There is currently no MYSQL_SYSVAR_xx that matches this, so I have added a MYSQL_SYSVAR_ULINT and changed the calls to this. See the attached patch. fix-600744.patch LPexportBug600744_fix-600744.patch
            Hide
            bothorsen Bo Thorsen added a comment -

            Re: XtraDB compile error with VS 10 64-bit
            The problem is that xtradb tries to store a ulint using unsigned long. This works on all architecures except 64 bit Windows because ulint is defined as __int64 on that. There is currently no MYSQL_SYSVAR_xx that matches this, so I have added a MYSQL_SYSVAR_ULINT and changed the calls to this. See the attached patch.

            Show
            bothorsen Bo Thorsen added a comment - Re: XtraDB compile error with VS 10 64-bit The problem is that xtradb tries to store a ulint using unsigned long. This works on all architecures except 64 bit Windows because ulint is defined as __int64 on that. There is currently no MYSQL_SYSVAR_xx that matches this, so I have added a MYSQL_SYSVAR_ULINT and changed the calls to this. See the attached patch.
            Hide
            bothorsen Bo Thorsen added a comment -

            New attempt at a patch. This one doesn't modify plugin.h but is local to xtradb.
            fix-600744.patch
            LPexportBug600744_fix-600744.patch

            Show
            bothorsen Bo Thorsen added a comment - New attempt at a patch. This one doesn't modify plugin.h but is local to xtradb. fix-600744.patch LPexportBug600744_fix-600744.patch
            Hide
            bothorsen Bo Thorsen added a comment -

            Re: XtraDB compile error with VS 10 64-bit
            New attempt at a patch. This one doesn't modify plugin.h but is local to xtradb.

            Show
            bothorsen Bo Thorsen added a comment - Re: XtraDB compile error with VS 10 64-bit New attempt at a patch. This one doesn't modify plugin.h but is local to xtradb.
            Hide
            bothorsen Bo Thorsen added a comment -

            Here is a smaller patch, which is the one I'll push to MariaDB.
            fix-600744.patch
            LPexportBug600744_fix-600744.patch

            Show
            bothorsen Bo Thorsen added a comment - Here is a smaller patch, which is the one I'll push to MariaDB. fix-600744.patch LPexportBug600744_fix-600744.patch
            Hide
            bothorsen Bo Thorsen added a comment -

            Re: XtraDB compile error with VS 10 64-bit
            Here is a smaller patch, which is the one I'll push to MariaDB.

            Show
            bothorsen Bo Thorsen added a comment - Re: XtraDB compile error with VS 10 64-bit Here is a smaller patch, which is the one I'll push to MariaDB.
            Hide
            stewart Stewart Smith added a comment -

            Re: XtraDB compile error with VS 10 64-bit
            All development of XtraDB has moved under the Percona Server project - https://launchpad.net/percona-server - If this bug can be reproduced against current Percona Server, please file this bug against percona-server (you can simply do so by using the "Also affects project" link above).

            Thanks,
            Stewart Smith
            Director of Server Development
            Percona.

            Show
            stewart Stewart Smith added a comment - Re: XtraDB compile error with VS 10 64-bit All development of XtraDB has moved under the Percona Server project - https://launchpad.net/percona-server - If this bug can be reproduced against current Percona Server, please file this bug against percona-server (you can simply do so by using the "Also affects project" link above). Thanks, Stewart Smith Director of Server Development Percona.
            Hide
            ratzpo Rasmus Johansson added a comment -

            Launchpad bug id: 600744

            Show
            ratzpo Rasmus Johansson added a comment - Launchpad bug id: 600744

              People

              • Assignee:
                Unassigned
                Reporter:
                hakanküçükyılmaz Hakan Küçükyılmaz
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: