Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:
Description
PBXT does not compile on 64 bit windows due to use of inline assembly (64 bit Visual C++ compiler does not support inline assembly)
Suggestion : use win32 atomics (InterlockedAdd etc) instead of assembly
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Re: pbxt does not compile on 64 bit windows
Hi Oleksandr,
Ignore my last comment. Vlad has just pointed out the problem to me. The Windows compiler does not handle #ifdef in macros.
I will push a fix shortly...
Re: pbxt does not compile on 64 bit windows
Hi Oleksandr,
The problems in ha_pbxt.cc should be fixed now.
Please try...
Re: pbxt does not compile on 64 bit windows
Hi!
Yes it fixed the problems. Thank you!
Re: pbxt does not compile on 64 bit windows
According to http://primebase.org/download/ChangeLog, this is fixed in 1.0.09f RC3 - 2009-11-30, and MariaDB-5.1.42 uses 1.0.09g so this bug is complete.
Atomic operations are the only thing that you don't do on 64-bit windows now
Launchpad bug id: 345524
Re: pbxt does not compile on 64 bit windows
Thanks for the bug report.
As far as I know, the win32 atomics do not support 1 and 2 bytes values. This is the reason for not using them before. But they may be the only option for 64 windows.