Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-2566

LP:347606 - Changes to configure.in have broken several BUILD scripts on Mac OSX 10.5

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      As stated in the summary, many of the scripts in the BUILD dir are broken on Mac OS X 10.5.

      compile-pentium-debug-max, compile-pentium-debug, etc no longer work and produce errors as documented in maria_mac_build_fail.txt.

      compile-pentium-gcov continues to work without fail.

      Undoing the following changes to configure.in allows for a successful build:

      Is this a need for updated tools, etc?

      === modified file 'configure.in'
      — old/configure.in 2009-03-12 22:27:35 +0000
      +++ new/configure.in 2009-03-22 20:23:20 +0000
      @@ -1677,14 +1677,17 @@ if test "$with_debug" = "yes"
      then

      1. Medium debug.
        AC_DEFINE([DBUG_ON], [1], [Use libdbug])
      • CFLAGS="$DEBUG_CFLAGS $DEBUG_OPTIMIZE_CC -DSAFE_MUTEX $CFLAGS"
      • CXXFLAGS="$DEBUG_CXXFLAGS $DEBUG_OPTIMIZE_CXX -DSAFE_MUTEX $CXXFLAGS"
        + AC_DEFINE([SAFE_MUTEX], [1], [Use safe mutexes])
        + CFLAGS="$DEBUG_CFLAGS $DEBUG_OPTIMIZE_CC $CFLAGS"
        + CXXFLAGS="$DEBUG_CXXFLAGS $DEBUG_OPTIMIZE_CXX $CXXFLAGS"
        elif test "$with_debug" = "full"
        then
      1. Full debug. Very slow in some cases
        AC_DEFINE([DBUG_ON], [1], [Use libdbug])
      • CFLAGS="$DEBUG_CFLAGS -DSAFE_MUTEX -DSAFEMALLOC $CFLAGS"
      • CXXFLAGS="$DEBUG_CXXFLAGS -DSAFE_MUTEX -DSAFEMALLOC $CXXFLAGS"
        + AC_DEFINE([SAFE_MUTEX], [1], [Use safe mutexes])
        + AC_DEFINE([SAFEMALLOC], [1], [Use safe malloc])
        + CFLAGS="$DEBUG_CFLAGS $CFLAGS"
        + CXXFLAGS="$DEBUG_CXXFLAGS $CXXFLAGS"
        else
      1. Optimized version. No debug
        AC_DEFINE([DBUG_OFF], [1], [Don't use libdbug])
        @@ -2812,6 +2815,7 @@ AC_CONFIG_FILES(Makefile extra/Makefile
        include/mysql_version.h plugin/Makefile win/Makefile)

      AC_CONFIG_COMMANDS([default], , test -z "$CONFIG_HEADERS" || echo timestamp > stamp-h)
      +AC_CONFIG_COMMANDS([my_config.h], cp include/config.h include/my_config.h)

      1. Ensure that table handlers gets all modifications to CFLAGS/CXXFLAGS
        AC_CONFIG_COMMANDS_POST(ac_configure_args="$ac_configure_args CFLAGS='$CFLAGS' CXXFLAGS='$CXXFLAGS'")

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            patrickcrews Patrick Crews added a comment -

            output of failing BUILD/compile-pentium-debug-max on Mac OSX 10.5
            LPexportBug347606_maria_mac_build_fail.txt

            Show
            patrickcrews Patrick Crews added a comment - output of failing BUILD/compile-pentium-debug-max on Mac OSX 10.5 LPexportBug347606_maria_mac_build_fail.txt
            Hide
            patrickcrews Patrick Crews added a comment -

            Re: Changes to configure.in have broken several BUILD scripts on Mac OSX 10.5

            Show
            patrickcrews Patrick Crews added a comment - Re: Changes to configure.in have broken several BUILD scripts on Mac OSX 10.5
            Hide
            patrickcrews Patrick Crews added a comment -

            Re: Changes to configure.in have broken several BUILD scripts on Mac OSX 10.5
            NOTE: As of 4/3/2009 this problem has gone away. Updates to the maria trees have allowed for successful builds on Mac OSX 10.5 again.

            I haven't changed the status of this bug yet and it should be up to maria-captains how they want to manage the bugs. However, the best two solutions I see are Invalid (technically true now, but not at the time of the bug report) or Fix released (I noticed changes to my_realloc and the other file that threw compile errors in the bug report)

            Show
            patrickcrews Patrick Crews added a comment - Re: Changes to configure.in have broken several BUILD scripts on Mac OSX 10.5 NOTE: As of 4/3/2009 this problem has gone away. Updates to the maria trees have allowed for successful builds on Mac OSX 10.5 again. I haven't changed the status of this bug yet and it should be up to maria-captains how they want to manage the bugs. However, the best two solutions I see are Invalid (technically true now, but not at the time of the bug report) or Fix released (I noticed changes to my_realloc and the other file that threw compile errors in the bug report)
            Hide
            knielsen Kristian Nielsen added a comment -

            Re: Changes to configure.in have broken several BUILD scripts on Mac OSX 10.5
            I pushed a fix for build errors in debug builds caused by the mentioned change to configure.in.

            I Don't recognise the build errors mentioned, but I assume they were fixed by the same fix.

            Show
            knielsen Kristian Nielsen added a comment - Re: Changes to configure.in have broken several BUILD scripts on Mac OSX 10.5 I pushed a fix for build errors in debug builds caused by the mentioned change to configure.in. I Don't recognise the build errors mentioned, but I assume they were fixed by the same fix.
            Hide
            ratzpo Rasmus Johansson added a comment -

            Launchpad bug id: 347606

            Show
            ratzpo Rasmus Johansson added a comment - Launchpad bug id: 347606

              People

              • Assignee:
                knielsen Kristian Nielsen
                Reporter:
                pcrews patrick crews
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: