Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-2352

LP:907894 - PASSWORD_QUESTION doesn't hide passwords in Release builds

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      I build the 5.5 version as
      cmake -DCMAKE_BUILD_TYPE=Release
      (no additional parameters)

      Then I install the plugin 'two_questions' and create a user identified via it.
      When I attempt to connect as this user using MySQL client, I get the prompt 'Password, please'. When I type in the password, it's displayed as a usual entry string.

      It doesn't happen if I build with CMAKE_BUILD_TYPE=Debug – the password gets hidden as usual.

      It seems to be only the matter of the MySQL client binary – with the same server and plugins, I get the expected behavior if I use the client binary from the debug build, and erroneous with the client binary from the release build.

      Same problem happens on buildbot builds, tried on two different machines, both openSUSE.

      Previous releases, e.g. 5.3, seem to work all right (tried the official release build and a buildbot build).

      bzr version-info
      revision-id: <email address hidden>
      date: 2011-12-21 23:40:26 +0100
      build-date: 2011-12-22 21:44:25 +0400
      revno: 3187
      branch-nick: maria-5.5

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            elenst Elena Stepanova added a comment -

            Re: PASSWORD_QUESTION doesn't hide passwords in Release builds
            With default CMAKE_BUILD_TYPE (RelWithDebInfo) the behavior is the same as with Release.

            Show
            elenst Elena Stepanova added a comment - Re: PASSWORD_QUESTION doesn't hide passwords in Release builds With default CMAKE_BUILD_TYPE (RelWithDebInfo) the behavior is the same as with Release.
            Hide
            elenst Elena Stepanova added a comment -

            Re: PASSWORD_QUESTION doesn't hide passwords in Release builds
            Fix released with 5.5.20.

            Show
            elenst Elena Stepanova added a comment - Re: PASSWORD_QUESTION doesn't hide passwords in Release builds Fix released with 5.5.20.
            Hide
            ratzpo Rasmus Johansson added a comment -

            Launchpad bug id: 907894

            Show
            ratzpo Rasmus Johansson added a comment - Launchpad bug id: 907894
            Hide
            niek niek dekker added a comment -

            I'm not sure if this is the same issue but a similar issue occurs in Mariadb 5.3.11 on FreeBSD.
            $ mysql -uusername -p
            $ Enter password:
            (the password is displayed while it is being entered)

            Version: mysql Ver 15.1 Distrib 5.3.11-MariaDB, for portbld-freebsd7.4 (amd64) using EditLine wrapper

            Show
            niek niek dekker added a comment - I'm not sure if this is the same issue but a similar issue occurs in Mariadb 5.3.11 on FreeBSD. $ mysql -uusername -p $ Enter password: (the password is displayed while it is being entered) Version: mysql Ver 15.1 Distrib 5.3.11-MariaDB, for portbld-freebsd7.4 (amd64) using EditLine wrapper
            Hide
            serg Sergei Golubchik added a comment -

            it cannot be the same, as far as I remember, the fixed one was only for 5.5, caused by the new cmake based build system.

            Show
            serg Sergei Golubchik added a comment - it cannot be the same, as far as I remember, the fixed one was only for 5.5, caused by the new cmake based build system.

              People

              • Assignee:
                serg Sergei Golubchik
                Reporter:
                elenst Elena Stepanova
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: