Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-2340

LP:665643 - Regressions in code coverage in sql_join_cache in maria-5.3-mwl128

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      The code coverage for sql_join_cache.cc has gone down significantly in maria-5.3-mwl128 as compared to 5.3-main. The report is available here:

      http://fedora13.selfip.org/lcov/maria-5.3/sql/sql_join_cache.cc.gcov.html
      http://fedora13.selfip.org/lcov/maria-5.3-mwl128/sql/sql_join_cache.cc.gcov.html

      The following items are not covered:

      • the bottom of JOIN_CACHE::alloc_buffer()
      • Several JOIN_CACHE_HASHED and JOIN_CACHE_BNLH functions
      • several bkah* and JOIN_CACHE_BKAH functions

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            philipstoev Philip Stoev added a comment -

            Re: Regressions in code coverage in sql_join_cache in maria-5.3-mwl128
            The reason seems to be that the join_cache test failed in the gcov build:

            main.join_cache w1 [ fail ]
            Test ended at 2010-10-23 19:22:36

            CURRENT_TEST: main.join_cache
            — /home/buildbot/rqg-buildbot-slave/perpush-gcov/build/mysql-test/r/join_cache.result 2010-10-23 18:43:27.124943000 +0300
            +++ /home/buildbot/rqg-buildbot-slave/perpush-gcov/build/mysql-test/r/join_cache.reject 2010-10-23 19:22:36.159247624 +0300
            @@ -4041,8 +4041,8 @@
            SГЈo Paulo Brazil
            London United Kingdom
            Santiago de Chile Chile
            -Alexandria Egypt
            Cairo Egypt
            +Alexandria Egypt
            Jakarta Indonesia
            Delhi India
            Calcutta [Kolkata] India

            ...

            Build and compile information are available from http://buildbot.askmonty.org/buildbot/builders/gcov/builds/38 . No idea why.

            Show
            philipstoev Philip Stoev added a comment - Re: Regressions in code coverage in sql_join_cache in maria-5.3-mwl128 The reason seems to be that the join_cache test failed in the gcov build: main.join_cache w1 [ fail ] Test ended at 2010-10-23 19:22:36 CURRENT_TEST: main.join_cache — /home/buildbot/rqg-buildbot-slave/perpush-gcov/build/mysql-test/r/join_cache.result 2010-10-23 18:43:27.124943000 +0300 +++ /home/buildbot/rqg-buildbot-slave/perpush-gcov/build/mysql-test/r/join_cache.reject 2010-10-23 19:22:36.159247624 +0300 @@ -4041,8 +4041,8 @@ SГЈo Paulo Brazil London United Kingdom Santiago de Chile Chile -Alexandria Egypt Cairo Egypt +Alexandria Egypt Jakarta Indonesia Delhi India Calcutta [Kolkata] India ... Build and compile information are available from http://buildbot.askmonty.org/buildbot/builders/gcov/builds/38 . No idea why.
            Hide
            philipstoev Philip Stoev added a comment -

            Re: Regressions in code coverage in sql_join_cache in maria-5.3-mwl128
            Igor pushed a --sort-result test case fix and the coverage percentages are back to normal.

            Show
            philipstoev Philip Stoev added a comment - Re: Regressions in code coverage in sql_join_cache in maria-5.3-mwl128 Igor pushed a --sort-result test case fix and the coverage percentages are back to normal.
            Hide
            ratzpo Rasmus Johansson added a comment -

            Launchpad bug id: 665643

            Show
            ratzpo Rasmus Johansson added a comment - Launchpad bug id: 665643

              People

              • Assignee:
                igor Igor Babaev
                Reporter:
                philipstoev Philip Stoev
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: