Details
-
Type:
Bug
-
Status: Closed
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:
Description
ourdelta-mariadb51-2/bakery/debian-5.1/dist/Ubuntu/mariadb-server-5.1.postinst has this:
"CREATE TABLE plugin (name char(64) COLLATE utf8_bin NOT NULL DEFAULT '', " \
" dl char(128) COLLATE utf8_bin NOT NULL DEFAULT '', " \
" PRIMARY KEY (name)) ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_bin COMMENT='MySQL plugins';\n" \
"INSERT INTO plugin VALUES ('innodb', 'ha_innodb.so');\n" \
"INSERT INTO plugin VALUES ('federated', 'ha_federated.so');\n" \
"INSERT INTO plugin VALUES ('blackhole', 'ha_blackhole.so');\n" \
"INSERT INTO plugin VALUES ('archive', 'ha_archive.so');" `
But when I unpack all of mariadb .deb files, I find only one plugin - ha_example.so. innodb, blackhole, archive seem to be compiled statically, federated seems to be compiled dynamically but missing.
The build and postinst script should be brought in sync.
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Re: deb package tries to add innodb,federated,blackhole as plugins while they arent
I am referring to the code in MariaDB. I have not checked this in OurDelta.
[Bug 454254] Re: deb package tries to add innodb, federated, blackhole as plugins while they arent
Hi!
>>>>> "Mark" == Mark Callaghan <mdcallag@gmail.com> writes:
Mark> Why have the built-in and plug-in versions of InnoDB been disabled? Disabled means I cannot compile them with MariaDB.
Mark> And why does XtraDB use the plugin name 'innobase' rather than 'xtradb' or 'xtradb_plugin'? Built-in InnoDB uses the name 'innobase' and plug-in InnoDB uses the name 'innodb_plugin'.
Mark> See storage/innobase/plug.in.disabled,
Mark> storage/innodb_plugin/plug.in.disabled, storage/xtradb/plug.in
The reason for disabling them is mainly because of time constraint to
get a release out. Feel free to fix so that one can decide on the
configure line which one wants to use.
The reason for the name 'xtradb' is, I assume, to make MariaDB use
xtradb instead of InnoDB without anyone having to change any options
when installing MariaDB to be used with an MySQL installation.
I personally don't see a reason to have both innobase_plugin and
xtradb used at the same time as xtradb will contains everthing and
more than innobase_plugin; The main reason to have innobase_plugin in
the tree is just to make it simpler when we pull code from the MySQL
tree.
<cut>
Regards,
Monty
Re: [Ourdelta-developers] [Bug 454254] Re: deb package tries to add innodb, federated, blackhole as plugins while they arent
Hi mark
On 19/10/2009, at 6:08 AM, Mark Callaghan wrote:
> Why have the built-in and plug-in versions of InnoDB been disabled?
> Disabled means I cannot compile them with MariaDB.
Ah, and you'd like to pehaps include your own InnoDB plugin? If we
leave 'em enabled, funny thnigs happen with tests and such. As
Kristian mentioned, it may well be possible to make it work, but it
was a bit finicky hence this approach for now.
> And why does XtraDB use the plugin name 'innobase' rather than
> 'xtradb' or 'xtradb_plugin'?
> Built-in InnoDB uses the name 'innobase' and plug-in InnoDB uses the
> name 'innodb_plugin'.
That's a fair question, and perhaps Percona has an answer to that.
I presume that even if it were called XtraDB, the options could still
also be called innodb_ for backward compatibility.
It's possible (or even likely) that XtraDB using the source names it
has causes the build problem...
> See storage/innobase/plug.in.disabled,
> storage/innodb_plugin/plug.in.disabled, storage/xtradb/plug.in
Yep.
Cheers,
Arjen.
–
Arjen Lentz, Exec.Director @ Open Query (http://openquery.com)
Exceptional Services for MySQL at a fixed budget.
Follow our blog at http://openquery.com/blog/
OurDelta: enhanced builds for MySQL @ http://ourdelta.org
Re: [Ourdelta-developers] [Bug 454254] Re: deb package tries to add innodb, federated, blackhole as plugins while they arent
On 19/10/2009, at 6:08 AM, Mark Callaghan wrote:
> Why have the built-in and plug-in versions of InnoDB been disabled?
> Disabled means I cannot compile them with MariaDB.
> And why does XtraDB use the plugin name 'innobase' rather than
> 'xtradb' or 'xtradb_plugin'?
> Built-in InnoDB uses the name 'innobase' and plug-in InnoDB uses the
> name 'innodb_plugin'.
Yes.
When I merged XtraDB, the idea was to replace built-in innodb with
XtraDB. Users should not have to do anything to switch to XtraDB.
This is based on the assumption that XtraDB will work at least as well as
built-in innodb for everybody. If this is not the case we of course need to
revisit the decision.
Also, when XtraDB was merged there was no facilities to have multiple versions
of InnoDB plugins in the source with multiple names. This was introduced later
with the merge of MySQL 5.1.39. We have been in a bit of a scramble to get
these two changes merged, and things are clearly not as elegant as they could
be.
One problem is the test suite. There are a number of tests that do not produce
the same result with built-in innodb and the innodb plugin / xtradb. I think
you will find that in MySQL 5.1.39, the innodb plugin is not well supported
and has very few tests run. In MariaDB it is vice versa, xtradb is fully
supported, and built-in innodb is not.
In the end, it's about limited resources. If we can just maintain xtradb, we
can use more time for other important stuff. If there is a need for keeping
built-in innodb going, we will have to put priority on that over something
else.
- Kristian.
Launchpad bug id: 454254
Re: deb package tries to add innodb,federated,blackhole as plugins while they arent
Why have the built-in and plug-in versions of InnoDB been disabled? Disabled means I cannot compile them with MariaDB.
And why does XtraDB use the plugin name 'innobase' rather than 'xtradb' or 'xtradb_plugin'? Built-in InnoDB uses the name 'innobase' and plug-in InnoDB uses the name 'innodb_plugin'.
See storage/innobase/plug.in.disabled, storage/innodb_plugin/plug.in.disabled, storage/xtradb/plug.in